steveloughran commented on pull request #27308:
URL: https://github.com/apache/spark/pull/27308#issuecomment-724121221


   This is user facing, unless SparkConf is considered private
   
   ```
   [INFO] Compiling 69 Scala sources to 
/Users/stevel/Projects/sparkwork/cloud-integration/cloud-examples/target/test-classes...
   [ERROR] 
/Users/stevel/Projects/sparkwork/cloud-integration/cloud-examples/src/test/scala/com/cloudera/spark/cloud/s3/commit/S3ACommitBulkDataSuite.scala:96:
 type mismatch;
    found   : Traversable[(String, String)]
    required: Iterable[(String, String)]
   [ERROR]     sparkConf.setAll(settings)
   [ERROR]                      ^
   ```
   
   And as the setAll[Traversable] isn't in the 2.x branch, it means that if you 
use the setAll methods, you cannot have code which compiles against both 
branches.
   
   I think a more graceful migration might be in order, such as restoring the 
removed method, but having it log at warn at runtime that the method will go 
away.
   
   At the very least, the change should be in the release notes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to