dongjoon-hyun commented on a change in pull request #30283:
URL: https://github.com/apache/spark/pull/30283#discussion_r520195743
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/LoggingPodStatusWatcher.scala
##########
@@ -77,9 +83,19 @@ private[k8s] class LoggingPodStatusWatcherImpl(
}
}
+ override def reset(): Unit = {
+ resourceTooOldReceived = false
+ }
+
override def onClose(e: KubernetesClientException): Unit = {
- logDebug(s"Stopping watching application $appId with last-observed phase
$phase")
- closeWatch()
+ logInfo(s"Stopping watching application $appId with last-observed phase
$phase")
+ if (e != null && e.getCode==HTTP_GONE) {
+ resourceTooOldReceived = true
+ logInfo(s"Got HTTP Gone code, resource version changed in k8s api: $e")
+ } else {
+ logInfo(s"Got proper termination code, closing watcher.")
Review comment:
Please remove this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
