huaxingao commented on a change in pull request #30285:
URL: https://github.com/apache/spark/pull/30285#discussion_r520241117



##########
File path: python/pyspark/ml/fpm.py
##########
@@ -408,19 +429,26 @@ def getSequenceCol(self):
         """
         return self.getOrDefault(self.sequenceCol)
 
-    @since("2.4.0")
     def findFrequentSequentialPatterns(self, dataset):
         """
         Finds the complete set of frequent sequential patterns in the input 
sequences of itemsets.
 
-        :param dataset: A dataframe containing a sequence column which is
-                        `ArrayType(ArrayType(T))` type, T is the item type for 
the input dataset.
-        :return: A `DataFrame` that contains columns of sequence and 
corresponding frequency.
-                 The schema of it will be:
-                 - `sequence: ArrayType(ArrayType(T))` (T is the item type)
-                 - `freq: Long`
-
         .. versionadded:: 2.4.0
+
+        Parameters
+        ----------
+        dataset : :py:class:`pyspark.sql.DataFrame`
+            A dataframe containing a sequence column which is
+            `ArrayType(ArrayType(T))` type, T is the item type for the input 
dataset.
+
+        Returns
+        -------
+        pyspark.sql.dataframe.DataFrame

Review comment:
       I finished the review. please go ahead with your follow-up. I should 
have submitted all the comments at the same time instead of doing single 
comment.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to