cloud-fan commented on a change in pull request #30245:
URL: https://github.com/apache/spark/pull/30245#discussion_r520285317
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/EquivalentExpressions.scala
##########
@@ -65,11 +65,74 @@ class EquivalentExpressions {
}
}
+ /**
+ * Adds only expressions which are common in each of given expressions, in a
recursive way.
+ * For example, given two expressions `(a + (b + (c + 1)))` and `(d + (e +
(c + 1)))`,
+ * the common expression `(c + 1)` will be added into `equivalenceMap`.
+ */
+ def addCommonExprs(exprs: Seq[Expression], addFunc: Expression => Boolean =
addExpr): Unit = {
+ val exprSetForAll = mutable.Set[Expr]()
+
+ addExprTree(exprs.head, (expr: Expression) => {
+ if (expr.deterministic) {
+ val e = Expr(expr)
+ if (exprSetForAll.contains(e)) {
+ true
+ } else {
+ exprSetForAll.add(e)
+ false
+ }
+ } else {
+ false
+ }
+ })
+
+ val commonExprSet = exprs.tail.foldLeft(exprSetForAll) { (exprSet, expr) =>
+ val otherExprSet = mutable.Set[Expr]()
+
+ addExprTree(expr, (innerExpr: Expression) => {
+ if (innerExpr.deterministic) {
Review comment:
Similar code appears twice. Can we create a method for it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
