sunchao commented on a change in pull request #30211:
URL: https://github.com/apache/spark/pull/30211#discussion_r520335157
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##########
@@ -784,6 +784,22 @@ class DataSourceV2SQLSuite
}
}
+ test("SPARK-33305: DROP TABLE should also invalidate cache") {
+ val t = "testcat.ns.t"
+ val view = "view"
+ withTable(t) {
+ withTempView(view) {
+ sql(s"CREATE TABLE $t USING foo AS SELECT id, data FROM source")
+ sql(s"CACHE TABLE $view AS SELECT id FROM $t")
+ checkAnswer(sql(s"SELECT * FROM $t"), spark.table("source"))
+ checkAnswer(sql(s"SELECT * FROM $view"),
spark.table("source").select("id"))
+
+ sql(s"DROP TABLE $t")
+
assert(spark.sharedState.cacheManager.lookupCachedData(spark.table(view)).isEmpty)
Review comment:
hmm can you elaborate? I thought this is checking that view is not
cached.
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala
##########
@@ -784,6 +784,22 @@ class DataSourceV2SQLSuite
}
}
+ test("SPARK-33305: DROP TABLE should also invalidate cache") {
+ val t = "testcat.ns.t"
+ val view = "view"
+ withTable(t) {
+ withTempView(view) {
+ sql(s"CREATE TABLE $t USING foo AS SELECT id, data FROM source")
+ sql(s"CACHE TABLE $view AS SELECT id FROM $t")
+ checkAnswer(sql(s"SELECT * FROM $t"), spark.table("source"))
+ checkAnswer(sql(s"SELECT * FROM $view"),
spark.table("source").select("id"))
+
+ sql(s"DROP TABLE $t")
+
assert(spark.sharedState.cacheManager.lookupCachedData(spark.table(view)).isEmpty)
Review comment:
hmm can you elaborate? I thought this is checking that `view` is not
cached.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
