beliefer commented on a change in pull request #29999:
URL: https://github.com/apache/spark/pull/29999#discussion_r520337999
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
##########
@@ -178,6 +179,142 @@ case class Like(left: Expression, right: Expression,
escapeChar: Char)
}
}
+abstract class LikeAllBase extends Expression with ImplicitCastInputTypes {
Review comment:
The current implementation requires the expression list to be foldable,
including literal. In addition, in my earliest implementation, `nullSafeEval`
also used the caching of each pattern. But through offline discussions with
@cloud-fan , there is no need to do this. The current implementation of
`doGenCode`, if it is all literal, has actually achieved the effect.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
