Github user squito commented on the pull request:
https://github.com/apache/spark/pull/5377#issuecomment-92436434
I'm definitely not an expert on this, but the code seemed OK to me. My
only concern -- is it possible to add a test that ensures data is actually
getting encrypting? Otherwise the unit tests could pass just by making
`encrypt = true` a no-op. I can't think of any way to do that, though -- maybe
its not possible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
