Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/5236#discussion_r28262452
--- Diff: docs/configuration.md ---
@@ -35,8 +35,20 @@ val conf = new SparkConf()
val sc = new SparkContext(conf)
{% endhighlight %}
-Note that we can have more than 1 thread in local mode, and in cases like
spark streaming, we may actually
-require one to prevent any sort of starvation issues.
+Note that we can have more than 1 thread in local mode, and in cases like
Spark Streaming, we may
+actually require one to prevent any sort of starvation issues.
+
+Properties that specify some time duration should be configured with a
unit of time.
+The following format is accepted:
+
+ 5s (seconds)
+ 25ms (milliseconds)
+ 10m or 10min (minutes)
+ 3h (hours)
+ 5d (days)
+ 1y (years)
+
+If no units are provided, the default unit specified in the documentation
is assumed.
--- End diff --
I wonder whether we should actually say this. The whole point of doing this
is to deprecate the old way of specifying these configs such that we don't have
to maintain the docs to include the old default units.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
