cloud-fan commented on a change in pull request #30299:
URL: https://github.com/apache/spark/pull/30299#discussion_r520566520
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -61,34 +61,38 @@ class SessionCatalog(
externalCatalogBuilder: () => ExternalCatalog,
globalTempViewManagerBuilder: () => GlobalTempViewManager,
functionRegistry: FunctionRegistry,
- conf: SQLConf,
hadoopConf: Configuration,
parser: ParserInterface,
- functionResourceLoader: FunctionResourceLoader) extends Logging {
+ functionResourceLoader: FunctionResourceLoader,
+ cacheSize: Int = SQLConf.get.tableRelationCacheSize,
+ cacheTTL: Long = SQLConf.get.metadataCacheTTL) extends Logging with
HasConf {
import SessionCatalog._
import CatalogTypes.TablePartitionSpec
// For testing only.
def this(
externalCatalog: ExternalCatalog,
functionRegistry: FunctionRegistry,
- conf: SQLConf) = {
+ staticConf: SQLConf) = {
Review comment:
The previous name `conf` is OK. `SQLConf` contains both static and
runtime configs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
