wangyum commented on a change in pull request #29999:
URL: https://github.com/apache/spark/pull/29999#discussion_r521135433
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/regexpExpressions.scala
##########
@@ -178,6 +180,86 @@ case class Like(left: Expression, right: Expression,
escapeChar: Char)
}
}
+/**
+ * Optimized version of LIKE ALL, when all pattern values are literal.
+ */
+abstract class LikeAllBase extends UnaryExpression with ImplicitCastInputTypes
with NullIntolerant {
+
+ protected def patterns: Seq[Any]
+
+ protected def isNotDefined: Boolean
+
+ override def inputTypes: Seq[DataType] = StringType :: Nil
+
+ override def dataType: DataType = BooleanType
+
+ override def nullable: Boolean = true
+
+ private lazy val hasNull: Boolean = patterns.contains(null)
+
+ private lazy val cache = patterns.filterNot(_ == null)
+ .map(s => Pattern.compile(StringUtils.escapeLikeRegex(s.toString, '\\')))
+
+ override def eval(input: InternalRow): Any = {
+ if (hasNull) {
+ null
Review comment:
```sql
spark-sql> select 'a' like all ('%a%', null);
NULL
spark-sql> select 'a' not like all ('%a%', null);
false
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
