cloud-fan commented on a change in pull request #30297:
URL: https://github.com/apache/spark/pull/30297#discussion_r521179168
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -1919,9 +1920,14 @@ case class ArrayPosition(left: Expression, right:
Expression)
b
""",
since = "2.4.0")
-case class ElementAt(left: Expression, right: Expression)
+case class ElementAt(
+ left: Expression,
+ right: Expression,
+ failOnError: Boolean = SQLConf.get.ansiEnabled)
Review comment:
Making it a parameter is more robust to retain this info. Otherwise, we
may change it when transform and copy the expresion.
This also helps if we want to support SAFE prefix like
https://cloud.google.com/bigquery/docs/reference/standard-sql/functions-and-operators
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
