sunchao commented on a change in pull request #29034:
URL: https://github.com/apache/spark/pull/29034#discussion_r521744365



##########
File path: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -863,7 +864,12 @@ case class ShowTablesCommand(
       // Show the information of tables.
       val tables =
         tableIdentifierPattern.map(catalog.listTables(db, 
_)).getOrElse(catalog.listTables(db))
-      tables.map { tableIdent =>
+      val filterCachedTables = if (showCached) {
+        tables.filter(table => 
sparkSession.catalog.isCached(table.quotedString))

Review comment:
       I think `SparkSession.table` inside the `isCached` method will create a 
`UnresolvedRelation` with `isStreaming = false`, and later on in the analysis 
this flag may cause failure when a streaming table is encountered with that 
flag.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to