jsoref commented on a change in pull request #30323:
URL: https://github.com/apache/spark/pull/30323#discussion_r521767390
##########
File path:
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/OperationState.java
##########
@@ -31,7 +31,7 @@
CANCELED(TOperationState.CANCELED_STATE, true),
CLOSED(TOperationState.CLOSED_STATE, true),
ERROR(TOperationState.ERROR_STATE, true),
- UNKNOWN(TOperationState.UKNOWN_STATE, false),
+ UNKNOWN(TOperationState.UNKNOWN_STATE, false),
Review comment:
Apparently this is a downstream for this:
https://github.com/apache/hive/search?q=UKNOWN_STATE, so I'll need to change
that first.
I'll drop this shortly. If you have any advice for steps I should take w/
that project, I'm open to advice. Otherwise, I'll do something similar to what
I did here (it took a number of days to produce this initial PR).
##########
File path: docs/monitoring.md
##########
@@ -421,7 +421,7 @@ to handle the Spark Context setup and tear down.
In addition to viewing the metrics in the UI, they are also available as JSON.
This gives developers
an easy way to create new visualizations and monitoring tools for Spark. The
JSON is available for
-both running applications, and in the history server. The endpoints are
mounted at `/api/v1`. Eg.,
+both running applications, and in the history server. The endpoints are
mounted at `/api/v1`. For example
Review comment:
https://github.com/apache/spark/pull/30323#discussion_r521447840
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/InsertSuite.scala
##########
@@ -35,7 +35,7 @@ import org.apache.spark.util.Utils
case class TestData(key: Int, value: String)
-case class ThreeCloumntable(key: Int, value: String, key1: String)
+case class ThreeColumntable(key: Int, value: String, key1: String)
Review comment:
Would this be ok?
```suggestion
case class ThreeColumnTable(key: Int, value: String, key1: String)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
