HeartSaVioR commented on a change in pull request #30347:
URL: https://github.com/apache/spark/pull/30347#discussion_r521961963
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala
##########
@@ -384,239 +384,166 @@ class UnsupportedOperationsSuite extends SparkFunSuite {
outputMode = Append
)
- // Inner joins: Multiple stream-stream joins supported only in append mode
- testBinaryOperationInStreamingPlan(
- "single inner join in append mode",
- _.join(_, joinType = Inner),
- outputMode = Append,
- streamStreamSupported = true)
-
- testBinaryOperationInStreamingPlan(
- "multiple inner joins in append mode",
- (x: LogicalPlan, y: LogicalPlan) => {
- x.join(y, joinType = Inner).join(streamRelation, joinType = Inner)
- },
- outputMode = Append,
- streamStreamSupported = true)
-
- testBinaryOperationInStreamingPlan(
- "inner join in update mode",
- _.join(_, joinType = Inner),
- outputMode = Update,
- streamStreamSupported = false,
- expectedMsg = "is not supported in Update output mode")
-
- // Full outer joins: only batch-batch is allowed
- testBinaryOperationInStreamingPlan(
- "full outer join",
- _.join(_, joinType = FullOuter),
- streamStreamSupported = false,
- batchStreamSupported = false,
- streamBatchSupported = false)
+ // stream-stream join
+ {
Review comment:
Without this bracket you can reduce many line changes which are hurdles
to review. That can be added later (after finished reviewing) as I mentioned in
my previous comment. Makes sense?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
