cloud-fan commented on a change in pull request #30300:
URL: https://github.com/apache/spark/pull/30300#discussion_r522077305
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/AliasAwareOutputExpression.scala
##########
@@ -25,19 +25,15 @@ import
org.apache.spark.sql.catalyst.plans.physical.{HashPartitioning, Partition
trait AliasAwareOutputExpression extends UnaryExecNode {
protected def outputExpressions: Seq[NamedExpression]
- protected def hasAlias: Boolean = outputExpressions.collectFirst { case _:
Alias => }.isDefined
+ private lazy val aliasMap = AttributeMap(outputExpressions.collect {
+ case a @ Alias(child: AttributeReference, _) => (child, a.toAttribute)
+ })
- protected def replaceAliases(exprs: Seq[Expression]): Seq[Expression] = {
- exprs.map {
- case a: AttributeReference => replaceAlias(a).getOrElse(a)
- case other => other
- }
- }
+ protected def hasAlias: Boolean = aliasMap.nonEmpty
- protected def replaceAlias(attr: AttributeReference): Option[Attribute] = {
- outputExpressions.collectFirst {
- case a @ Alias(child: AttributeReference, _) if
child.semanticEquals(attr) =>
- a.toAttribute
+ protected def normalizeExpression(exp: Expression): Expression = {
+ exp.transform {
+ case attr: AttributeReference => aliasMap.get(attr).getOrElse(attr)
Review comment:
nit: `aliasMap.getOrElse(attr)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
