Ngone51 commented on a change in pull request #30164:
URL: https://github.com/apache/spark/pull/30164#discussion_r522116263
##########
File path:
resource-managers/yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
##########
@@ -80,6 +81,18 @@ private[spark] abstract class YarnSchedulerBackend(
/** Attempt ID. This is unset for client-mode schedulers */
private var attemptId: Option[ApplicationAttemptId] = None
+ private val blockManagerMaster: BlockManagerMaster =
sc.env.blockManager.master
+
+ private val minMergersThresholdRatio =
+ conf.get(config.SHUFFLE_MERGER_LOCATIONS_MIN_THRESHOLD_RATIO)
+
+ private val minMergersStaticThreshold =
+ conf.get(config.SHUFFLE_MERGER_LOCATIONS_MIN_STATIC_THRESHOLD)
+
+ private val maxNumExecutors = conf.get(DYN_ALLOCATION_MAX_EXECUTORS)
+
+ private val numExecutors = conf.get(EXECUTOR_INSTANCES).getOrElse(0)
Review comment:
Could you make the calls on confs be consistent? Either all use
`config.xxx` or import them directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
