Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28287180
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/Exchange.scala ---
@@ -33,7 +32,11 @@ import org.apache.spark.util.MutablePair
* :: DeveloperApi ::
*/
@DeveloperApi
-case class Exchange(newPartitioning: Partitioning, child: SparkPlan)
extends UnaryNode {
+case class Exchange(
+ newPartitioning: Partitioning,
+ child: SparkPlan,
+ sort: Boolean = false)
--- End diff --
Nit, I would put the child last as we do with most other operators even
though this requires a little more refactoring.
Can you also add scaladoc for the parameters? (sorry there is not some
there already!)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
