cloud-fan commented on a change in pull request #30357:
URL: https://github.com/apache/spark/pull/30357#discussion_r522664181
##########
File path: sql/core/src/test/resources/sql-tests/inputs/ansi/json-functions.sql
##########
@@ -0,0 +1 @@
+--IMPORT json-functions.sql
Review comment:
It's a bit overkill to rerun the entire test with ansi mode. What we
really care about is the parsing of schema string.
How about we add a new test `parse-schema-string.sql`, which only tests
`from_json`, `from_csv` with schema string?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
