leanken commented on pull request #30042: URL: https://github.com/apache/spark/pull/30042#issuecomment-726589343
> Sorry, we may need to revert this. I got feedback about these 2 APIs, which can be valid use cases: Users don't want to pass a `SparkSession` parameter all the way around, and want to leverage the set ad get API (The same reason for using SQLConf.get in Spark). > > On the other hand, these 2 APIs are not very risky. Spark always wrap rules execution with `session.withActive`, so end-users can't really change the active session in the middle(active session is thread-local). It's not 100% safe as users can write a UDF to change active session, and the UDF can be executed in the middle by the constant folding rule, but that's a really corner case. > > @leanken what do you think? OK. I will do the revert. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
