tgravescs commented on pull request #30349: URL: https://github.com/apache/spark/pull/30349#issuecomment-726795476
yeah I didn't realize that Suite was in different module, it makes sense it put it all in one place. it looks like ./common/network-yarn doesn't have dependencies for yarn (only Hadoop client) whereas ./resource-managers/yarn does. the tests aren't doing much with yarn it just calling your static function for newMergedShuffleFileManagerInstance and it builds with just the client so it seems like that should be enough. If tests pass I think its fine to merge as it makes sense just to combine into single file. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
