dongjoon-hyun commented on a change in pull request #27735:
URL: https://github.com/apache/spark/pull/27735#discussion_r523274226
##########
File path:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/deploy/k8s/Fabric8Aliases.scala
##########
@@ -16,14 +16,18 @@
*/
package org.apache.spark.deploy.k8s
-import io.fabric8.kubernetes.api.model.{DoneablePod, HasMetadata, Pod, PodList}
+import io.fabric8.kubernetes.api.model.{ConfigMap, ConfigMapList,
DoneableConfigMap, DoneablePod, HasMetadata, Pod, PodList}
import io.fabric8.kubernetes.client.{Watch, Watcher}
-import io.fabric8.kubernetes.client.dsl.{FilterWatchListDeletable,
MixedOperation, NamespaceListVisitFromServerGetDeleteRecreateWaitApplicable,
PodResource}
+import io.fabric8.kubernetes.client.dsl.{FilterWatchListDeletable,
MixedOperation, NamespaceListVisitFromServerGetDeleteRecreateWaitApplicable,
PodResource, Resource}
object Fabric8Aliases {
type PODS = MixedOperation[Pod, PodList, DoneablePod, PodResource[Pod,
DoneablePod]]
+ type CONFIG_MAPS = MixedOperation[ConfigMap,
+ ConfigMapList, DoneableConfigMap, Resource[ConfigMap, DoneableConfigMap]]
Review comment:
If you don't mind, shall we use like the following
```scala
- type CONFIG_MAPS = MixedOperation[ConfigMap,
- ConfigMapList, DoneableConfigMap, Resource[ConfigMap,
DoneableConfigMap]]
+ type CONFIG_MAPS = MixedOperation[
+ ConfigMap, ConfigMapList, DoneableConfigMap, Resource[ConfigMap,
DoneableConfigMap]]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
