maropu commented on a change in pull request #30341:
URL: https://github.com/apache/spark/pull/30341#discussion_r523419617
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/InterpretedUnsafeProjection.scala
##########
@@ -33,6 +34,15 @@ import org.apache.spark.unsafe.Platform
class InterpretedUnsafeProjection(expressions: Array[Expression]) extends
UnsafeProjection {
import InterpretedUnsafeProjection._
+ private[this] val subExprElimination =
SQLConf.get.subexpressionEliminationEnabled
Review comment:
nit: `subExprElimination` -> `subExprEliminationEnabled`?
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/SubExprEvaluationRuntime.scala
##########
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.sql.catalyst.expressions
+
+import scala.collection.mutable
+
+import com.google.common.cache.{CacheBuilder, CacheLoader, LoadingCache}
+import com.google.common.util.concurrent.{ExecutionError,
UncheckedExecutionException}
+
+import org.apache.spark.sql.catalyst.InternalRow
+import org.apache.spark.sql.catalyst.expressions.codegen.{CodegenContext,
ExprCode}
+import org.apache.spark.sql.types.DataType
+
+/**
+ * This class helps subexpression elimination for interpreted evaluation
+ * such as `InterpretedUnsafeProjection`. It maintains an evaluation cache.
+ * This class wraps `ExpressionProxy` around given expressions. The
`ExpressionProxy`
+ * intercepts expression evaluation and loads from the cache first.
+ */
+class SubExprEvaluationRuntime(cacheMaxEntries: Int) {
+
+ private[sql] val cache: LoadingCache[ExpressionProxy, ResultProxy] =
CacheBuilder.newBuilder()
+ .maximumSize(cacheMaxEntries)
+ .build(
+ new CacheLoader[ExpressionProxy, ResultProxy]() {
+ override def load(expr: ExpressionProxy): ResultProxy = {
+ ResultProxy(expr.proxyEval(currentInput))
+ }
+ })
+
+ private var currentInput: InternalRow = null
+
+ def getEval(proxy: ExpressionProxy): Any = try {
+ cache.get(proxy).result
+ } catch {
+ // Cache.get() may wrap the original exception. See the following URL
+ //
http://google.github.io/guava/releases/14.0/api/docs/com/google/common/cache/
+ // Cache.html#get(K,%20java.util.concurrent.Callable)
+ case e @ (_: UncheckedExecutionException | _: ExecutionError) =>
+ throw e.getCause
+ }
+
+ /**
+ * Sets given input row as current row for evaluating expressions. This
cleans up the cache
+ * too as new input comes.
+ */
+ def setInput(input: InternalRow = null): Unit = {
+ currentInput = input
+ cache.invalidateAll()
+ }
+
+ /**
+ * Recursively replaces expression with its proxy expression in `proxyMap`.
+ */
+ private def replaceWithProxy(
+ expr: Expression,
+ proxyMap: Map[Expression, ExpressionProxy]): Expression = {
+ expr match {
+ case e if proxyMap.contains(e) =>
+ proxyMap(e)
+ case _ =>
+ expr.mapChildren(replaceWithProxy(_, proxyMap))
Review comment:
nit: `proxyMap.getOrElse(expr, expr.mapChildren(replaceWithProxy(_,
proxyMap)))`?
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/InterpretedUnsafeProjection.scala
##########
@@ -33,6 +34,15 @@ import org.apache.spark.unsafe.Platform
class InterpretedUnsafeProjection(expressions: Array[Expression]) extends
UnsafeProjection {
import InterpretedUnsafeProjection._
+ private[this] val subExprElimination =
SQLConf.get.subexpressionEliminationEnabled
+ private[this] lazy val runtime =
+ new
SubExprEvaluationRuntime(SQLConf.get.subexpressionEliminationCacheMaxEntries)
+ private[this] val proxyExpressions = if (subExprElimination) {
Review comment:
nit: In case of `subExprElimination=false` or no common subexprs, this
variable is not related to a "proxy", so how about just calling it `exprs`?
(`proxyExpressions` -> `exprs`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
