pgillet commented on a change in pull request #30352:
URL: https://github.com/apache/spark/pull/30352#discussion_r523832187
##########
File path:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
##########
@@ -827,13 +851,14 @@ private[spark] class MesosClusterScheduler(
status: Int): Unit = {}
private def removeFromQueuedDrivers(subId: String): Boolean = {
Review comment:
You are right: this is exactly the same logic! But the old
implementation could not be kept that way due to the `queuedDrivers` collection
whose type has changed from `ArrayBuffer` to `mutable.TreeSet`. In a
`mutable.TreeSet`, you can remove an element by specifying the actual element,
but you can't remove an element by its index.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
