Victsm commented on a change in pull request #30163:
URL: https://github.com/apache/spark/pull/30163#discussion_r523862805
##########
File path:
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalBlockStoreClient.java
##########
@@ -158,6 +158,34 @@ public void pushBlocks(
}
}
+ @Override
+ public void finalizeShuffleMerge(
+ String host,
+ int port,
+ int shuffleId,
+ MergeFinalizerListener listener) {
+ checkInit();
+ try {
+ TransportClient client = clientFactory.createClient(host, port);
+ ByteBuffer finalizeShuffleMerge = new FinalizeShuffleMerge(appId,
shuffleId).toByteBuffer();
+ client.sendRpc(finalizeShuffleMerge, new RpcResponseCallback() {
+ @Override
+ public void onSuccess(ByteBuffer response) {
+ listener.onShuffleMergeSuccess(
+ (MergeStatuses)
BlockTransferMessage.Decoder.fromByteBuffer(response));
+ }
+
+ @Override
+ public void onFailure(Throwable e) {
+ listener.onShuffleMergeFailure(e);
+ }
+ });
+ } catch (Exception e) {
+ logger.error("Exception while sending finalizeShuffleMerge request to
{}:{}",
Review comment:
Yes, this is a good catch.
`onShuffleMergeFailure` should be called here as well.
It won't cause an endless waiting in the current implementation though, as
the caller (a separate thread in DAGScheduler) would bound the wait for getting
merge results from all related shuffle service locations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
