c21 commented on a change in pull request #30347:
URL: https://github.com/apache/spark/pull/30347#discussion_r523980835
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala
##########
@@ -414,209 +412,135 @@ class UnsupportedOperationsSuite extends SparkFunSuite {
batchStreamSupported = false,
streamBatchSupported = false)
- // Left outer joins: *-stream not allowed
+ // Left outer, left semi, left anti join: *-stream not allowed
+ Seq((LeftOuter, "LeftOuter join"), (LeftSemi, "LeftSemi join"), (LeftAnti,
"Left anti join"))
Review comment:
@xuanyuanking - wondering what's the naming style we are trying to
following here? TBH I would be surprised that someone fails to understand
comment of `left outer`, if I omit `join` here. Similar comments happened
several times in other files e.g. in
[StreamingSymmetricHashJoinExec](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinExec.scala#L325)
. But anyway I feel it's too nit, if you think it's worth the change, I can do
it as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
