Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4602#discussion_r28303497
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/namedExpressions.scala
 ---
    @@ -112,6 +112,8 @@ case class Alias(child: Expression, name: String)(
       extends NamedExpression with trees.UnaryNode[Expression] {
     
       override type EvaluatedType = Any
    +  // Alias(Generator, xx) need to be transformed into Generate(generator, 
...)
    +  override lazy val resolved = childrenResolved && 
!child.isInstanceOf[Generator]
    --- End diff --
    
    @marmbrus sorry, I am not so sure your mean, most of change that I made is 
move the `aliases` from `Generator` to `Generate`, which means `Generator` 
developers will not cares about the aliases any more.
    The `Alias(Generator, xx)` here will be transformed to `Generate(generator, 
aliases)`, that's why I marked it as `unresolved` for Alias.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to