MichaelChirico commented on pull request #28386: URL: https://github.com/apache/spark/pull/28386#issuecomment-728044077
collapse is an aggregation method. input is length>1 & collapse guarantees length-1 output. what's happening is separate has variable return length -- usually it returns a length-1 character vector but when the expression is large it has length>1. the bug fixed in this PR arises because of logic written assuming the output is always length 1 (see also the referenced Jira) On Mon, Nov 16, 2020, 4:47 AM Hyukjin Kwon <[email protected]> wrote: > It makes sense from my look but I would like other reviewers to double > check. I speak R as a second language :-). > @zero323 <https://github.com/zero323> and @danzafar > <https://github.com/danzafar> would you mind taking a look when you guys > find some time? > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/spark/pull/28386#issuecomment-727864798>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AB2BA5JL3HQPXV263WPNWZTSQDYJRANCNFSM4MSRSW3A> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
