cloud-fan commented on a change in pull request #30386:
URL: https://github.com/apache/spark/pull/30386#discussion_r524280730
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeExtractors.scala
##########
@@ -352,14 +357,25 @@ trait GetMapValueUtil extends BinaryExpression with
ImplicitCastInputTypes {
}
}
- if (!found || values.isNullAt(i)) {
+ if (!found) {
+ if (failOnError) {
+ throw new NoSuchElementException(s"Key $ordinal does not exist.")
+ } else {
+ null
+ }
+ }
+ else if (values.isNullAt(i)) {
Review comment:
nit: merge it to the previous line.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
