HeartSaVioR commented on a change in pull request #30347:
URL: https://github.com/apache/spark/pull/30347#discussion_r524584305
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationsSuite.scala
##########
@@ -414,209 +412,135 @@ class UnsupportedOperationsSuite extends SparkFunSuite {
batchStreamSupported = false,
streamBatchSupported = false)
- // Left outer joins: *-stream not allowed
+ // Left outer, left semi, left anti join: *-stream not allowed
+ Seq((LeftOuter, "LeftOuter join"), (LeftSemi, "LeftSemi join"), (LeftAnti,
"Left anti join"))
Review comment:
This is nit but super easy to fix, so probably better to fix now once we
find it. It'd be appreciated if you can fix this - won't drag the review
process as @xuanyuanking already provided LGTM and this is probably going to be
a final review comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
