pgillet commented on a change in pull request #30352:
URL: https://github.com/apache/spark/pull/30352#discussion_r524704610
##########
File path:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
##########
@@ -131,6 +132,8 @@ private[spark] class MesosClusterScheduler(
private val queuedCapacity = conf.get(config.MAX_DRIVERS)
private val retainedDrivers = conf.get(config.RETAINED_DRIVERS)
private val maxRetryWaitTime =
conf.get(config.CLUSTER_RETRY_WAIT_MAX_SECONDS)
+ private val queues: immutable.Map[String, Float] =
+ conf.getAllWithPrefix("spark.mesos.dispatcher.queue.").map(t => (t._1,
t._2.toFloat)).toMap
Review comment:
A `NumberFormatException` is thrown like following:
```
java.lang.NumberFormatException: For input string: "abc"
at
sun.misc.FloatingDecimal.readJavaFormatString(FloatingDecimal.java:2043)
at sun.misc.FloatingDecimal.parseFloat(FloatingDecimal.java:122)
at java.lang.Float.parseFloat(Float.java:451)
at scala.collection.immutable.StringLike.toFloat(StringLike.scala:315)
...
```
I added a test case that ensures that a `NumberFormatException` is well
thrown.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
