GitHub user zhichao-li opened a pull request:
https://github.com/apache/spark/pull/5508
[SPARK-6897][Streaming]remove volatile from BlockingGenerator.currentBuffer
to reduce unnecessary overhead
currentBuffer has been protected by synchronized, so it would introduce
unnecessary overhead for adding an extra volatile modifier here.
Hi @srowen , Found this while walking through the source code, could you
pls review if we need to take this since it's only a trivial stuff ?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhichao-li/spark volatile
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/5508.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5508
----
commit 40f0215190f4c5edd42e3dee17356a32cf11a4f0
Author: lisurprise <[email protected]>
Date: 2015-04-14T08:16:08Z
remove volatile to reduce unnecessary overhead
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
