LuciferYang commented on a change in pull request #30351:
URL: https://github.com/apache/spark/pull/30351#discussion_r524871258
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
##########
@@ -894,10 +893,6 @@ trait ScalaReflection extends Logging {
import universe._
- // The Predef.Map is scala.collection.immutable.Map.
- // Since the map values can be mutable, we explicitly import
scala.collection.Map at here.
- import scala.collection.Map
-
Review comment:
@srowen @HyukjinKwon
Actually there are 2 `import scala.collection.Map` in
`ScalaReflection.scala`, one is
https://github.com/apache/spark/blob/5af5aa146ecbff38b809127b5eb9805441627ed2/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala#L50-L63
the other one is
https://github.com/apache/spark/blob/5af5aa146ecbff38b809127b5eb9805441627ed2/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala#L888-L899
this pr removed the `import scala.collection.Map` in the `trait
ScalaReflection` not in the `object ScalaReflection`, The use of
`scala.collection.Map` is in `object ScalaReflection` not in `trait
ScalaReflection`, or move this import to the header of this file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
