dongjoon-hyun commented on a change in pull request #30399:
URL: https://github.com/apache/spark/pull/30399#discussion_r525337427
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/StringExpressionsSuite.scala
##########
@@ -943,6 +943,21 @@ class StringExpressionsSuite extends SparkFunSuite with
ExpressionEvalHelper {
GenerateUnsafeProjection.generate(ParseUrl(Seq(Literal("\"quote"),
Literal("\"quote"))) :: Nil)
}
+ test("SPARK-33468: ParseUrl should fail if input string is not a valid url")
{
+ // fail on error if in ansi mode.
Review comment:
We can remove this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
