Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5395#discussion_r28346669
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveInspectors.scala ---
    @@ -213,8 +215,16 @@ private[hive] trait HiveInspectors {
     
         case c: Class[_] if c.isArray => 
ArrayType(javaClassToDataType(c.getComponentType))
     
    +    // list type
    +    case c: Class[_] if c == classOf[java.util.List[java.lang.Object]] =>
    +      logWarning("Failed to catch a correct component type in List<> 
because of type erasure," +
    +        " so you need to handle it correctly by yourself")
    --- End diff --
    
    I'm not sure the best one as this warning message.
    Is " so you need to cast it into the correct type by yourself" ok?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to