dongjoon-hyun commented on a change in pull request #30412:
URL: https://github.com/apache/spark/pull/30412#discussion_r526254628
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala
##########
@@ -147,8 +147,10 @@ object DataSourceV2Relation {
catalog: Option[CatalogPlugin],
identifier: Option[Identifier],
options: CaseInsensitiveStringMap): DataSourceV2Relation = {
- val output = table.schema().toAttributes
- DataSourceV2Relation(table, output, catalog, identifier, options)
+ // The v2 source may return schema containing char/varchar type. We
replace char/varchar
+ // with string type here as Spark's type system doesn't support
char/varchar yet.
Review comment:
`with string type` -> `with string type with metadata`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
