Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5501#discussion_r28355633
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1855,6 +1857,28 @@ object SparkContext extends Logging {
}
/**
+ * Because we can only have one active Spark Context per JVM and there
are times when multiple
+ * applications may wish to share a SparkContext, this function may be
used to get or instantiate
+ * a SparkContext and register it as a singleton object.
+ *
+ * Note: This function cannot be used to create multiple spark contexts
even if multiple contexts
+ * are allowed. Multiple contexts will still need to be created with
explicit calls to the
+ * SparkContext constructor.
+ */
+ def getOrCreate(config: SparkConf): SparkContext = {
+ if (activeContext.get() != null) {
+ setActiveContext(new SparkContext(config),
--- End diff --
BTW, on top of Andrew's comments, this method is not thread-safe. If two
threads call it, you may have both trying to create a new SparkContext, and one
of them will end up throwing.
So you probably want to make this method synchronized.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
