cloud-fan commented on a change in pull request #30412:
URL: https://github.com/apache/spark/pull/30412#discussion_r526632969
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TableOutputResolver.scala
##########
@@ -93,19 +94,17 @@ object TableOutputResolver {
tableAttr.metadata == queryExpr.metadata) {
Some(queryExpr)
} else {
- // Renaming is needed for handling the following cases like
- // 1) Column names/types do not match, e.g., INSERT INTO TABLE tab1
SELECT 1, 2
- // 2) Target tables have column metadata
- storeAssignmentPolicy match {
+ val casted = storeAssignmentPolicy match {
case StoreAssignmentPolicy.ANSI =>
- Some(Alias(
- AnsiCast(queryExpr, tableAttr.dataType,
Option(conf.sessionLocalTimeZone)),
- tableAttr.name)(explicitMetadata = Option(tableAttr.metadata)))
+ AnsiCast(queryExpr, tableAttr.dataType,
Option(conf.sessionLocalTimeZone))
case _ =>
- Some(Alias(
- Cast(queryExpr, tableAttr.dataType,
Option(conf.sessionLocalTimeZone)),
- tableAttr.name)(explicitMetadata = Option(tableAttr.metadata)))
+ Cast(queryExpr, tableAttr.dataType,
Option(conf.sessionLocalTimeZone))
}
+ val strLenChecked = CharVarcharUtils.stringLengthCheck(casted, tableAttr)
Review comment:
> To avoid accidentally adding the length check exprs again, we cannot
remove the metadata at the same time as adding the exprs?
We can't access the table relation here, only table output attrs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
