dongjoon-hyun commented on a change in pull request #30428:
URL: https://github.com/apache/spark/pull/30428#discussion_r527187754
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala
##########
@@ -252,7 +244,9 @@ object PROCESS_TABLES extends QueryTest with SQLTestUtils {
// do not throw exception during object initialization.
case NonFatal(_) => Seq("3.0.1", "2.4.7") // A temporary fallback to use
a specific version
}
- versions.filter(v => v.startsWith("3") ||
!TestUtils.isPythonVersionAtLeast38())
+ versions
+ .filter(v => v.startsWith("3") || !TestUtils.isPythonVersionAtLeast38())
+ .filter(v => v.startsWith("3") ||
!SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_11))
Review comment:
Shall we use `JavaVersion.JAVA_9` to be consistent with the PR title
`~~~ at JDK9+`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
