HeartSaVioR commented on a change in pull request #30336:
URL: https://github.com/apache/spark/pull/30336#discussion_r527252370
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala
##########
@@ -178,14 +178,14 @@ object StateStoreMetrics {
trait StateStoreCustomMetric {
def name: String
def desc: String
- def unit: String
+ def unit: String = ""
}
-case class StateStoreCustomSumMetric(name: String, desc: String, unit: String)
+case class StateStoreCustomSumMetric(name: String, desc: String, override val
unit: String)
Review comment:
We also would like to not break these three classes as well, either
providing default value or providing two params constructor which would set
`unit` as default value (`""`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
