HeartSaVioR edited a comment on pull request #30366: URL: https://github.com/apache/spark/pull/30366#issuecomment-730695183
> LGTM. Note we've got one more change due on hadoop-common to use UTC as the issue date. > > This raises another question: what to do if the issue date > now? That is it thinks it was issued a few hours into the future? What happens then? AFAIK we don't have any guard around that. If the result of `token.renew()` is later than issue date, we still get correct value of renew interval, but calculating next renewal date would be problematic as we get it via `issue date + renew interval`. We finally calculate the schedule interval for the next renewal via `next renewal date - now`. If the renewal date goes to be less than now, we adjust the negative value as 0, and continuous scheduling without delay happens like I described in the PR description. If the renewal date goes to be higher than actual expire date, well, we know the result already. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
