allisonwang-db opened a new pull request #30437:
URL: https://github.com/apache/spark/pull/30437


   Backport #30373 for branch-2.4.
   
   ### What changes were proposed in this pull request?
   This PR switched the order for the rule `RemoveRedundantSorts` and 
`EnsureRequirements` so that `EnsureRequirements` will be invoked before 
`RemoveRedundantSorts` to avoid IllegalArgumentException when instantiating 
PartitioningCollection.
   
   ### Why are the changes needed?
   `RemoveRedundantSorts` rule uses SparkPlan's `outputPartitioning` to check 
whether a sort node is redundant. Currently, it is added before 
`EnsureRequirements`. Since `PartitioningCollection` requires left and right 
partitioning to have the same number of partitions, which is not necessarily 
true before applying `EnsureRequirements`, the rule can fail with the following 
exception:
   ```
   IllegalArgumentException: requirement failed: PartitioningCollection 
requires all of its partitionings have the same numPartitions.
   ```
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   Unit test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to