maryannxue commented on a change in pull request #30432:
URL: https://github.com/apache/spark/pull/30432#discussion_r527929537
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/ShuffleExchangeExec.scala
##########
@@ -56,10 +56,27 @@ trait ShuffleExchangeLike extends Exchange {
*/
def numPartitions: Int
+ def partitioningFlexibility: PartitioningFlexibility.Value
+
/**
* Returns whether the shuffle partition number can be changed.
*/
- def canChangeNumPartitions: Boolean
+ def canChangeNumPartitions: Boolean = {
Review comment:
I feel like these two methods are redundant if we have
`partitioningFlexibilty` already.
I know that removing these methods would cause more code changes on the
caller side, but for the integrity and simplicity of the interface, it's
probably worth it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
