mridulm edited a comment on pull request #30446:
URL: https://github.com/apache/spark/pull/30446#issuecomment-731400801


   Redaction support looks kind of inconsistent.
   For `ApplicationEnvironmentInfo`, the event file contains unredacted event 
with the api redacting on demand.
   On other hand, `SparkListenerEnvironmentUpdate` is redacted before getting 
logged into event file.
   
   The current pr takes the approach of `SparkListenerEnvironmentUpdate` - and 
logs redacted events.
   Personally I am inclined to have source of truth in the event file, and 
expose redacted view.
   
   But then, all of these was last changed 4 years or so back (#15971).
   Any thoughts @vanzin, @tgravescs ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to