xkrogen commented on pull request #30450: URL: https://github.com/apache/spark/pull/30450#issuecomment-731446529
@otterc regarding a unit test, I did think about this but it looks like to unit test it, we'll need to do some refactoring to pull `YarnClient` out, and mock its responses. It should be doable, just not sure if the setup effort is worth it for this small patch. FWIW the previous unit tests were only testing the parsing logic, which is now handled by YARN code. I'm happy to put in the refactoring work for a unit test if others feel it's necessary here. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
