Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/5428#discussion_r28384469
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/Checkpoint.scala ---
@@ -77,7 +77,8 @@ object Checkpoint extends Logging {
}
/** Get checkpoint files present in the give directory, ordered by
oldest-first */
- def getCheckpointFiles(checkpointDir: String, fs: FileSystem): Seq[Path]
= {
+ def getCheckpointFiles(checkpointDir: String, fsOption:
Option[FileSystem] = None): Seq[Path] = {
--- End diff --
The reason I added this is so that we should not have to handle nulls.
Dealing with nulls is severely frowned upon in Sclaa, and precisely why Option
was introduced. There are many places where this has been done, and slowly I
was fix those. I think this is a small enough change (doesnt change
functionality, or existing code paths) that is okay to do this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
