AngersZhuuuu commented on a change in pull request #30451:
URL: https://github.com/apache/spark/pull/30451#discussion_r528220943
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/package.scala
##########
@@ -103,6 +103,7 @@ package object client {
// Since HIVE-14496, Hive materialized view need calcite-core.
// For spark, only VersionsSuite currently creates a hive materialized
view for testing.
case object v2_3 extends HiveVersion("2.3.7",
+ extraDeps = Seq("org.apache.zookeeper:zookeeper:3.4.6"),
Review comment:
I tried in feature https://github.com/apache/spark/pull/29966 to
download zookeeper-3.4.6(after clean cache)
```
test("SPARK-33084: Add jar support ivy url") {
sc = new SparkContext(new
SparkConf().setAppName("test").setMaster("local-cluster[3, 1, 1024]"))
sc.addJar("ivy://org.apache.zookeeper:zookeeper:3.4.6")
println("+===================+")
sc.listJars().foreach(println)
assert(sc.listJars().find(_.contains("zookeeper-3.4.6")).nonEmpty)
}
```
It really download right jar.
But with UT
```
test("SPARK-33084: Add jar support ivy url") {
sc = new SparkContext(new SparkConf().setAppName("test")
.setMaster("local-cluster[3, 1, 1024]"))
sc.addJar("ivy://org.apache.hive:hive-exec:2.3.7" +
"?exclude=org.pentaho:pentaho-aggdesigner-algorithm&transitive=true")
println("+===================+")
sc.listJars().foreach(println)
}
```
It download both zookeeper.jar and zookeeper-test.jar.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
