wangyum commented on a change in pull request #29642:
URL: https://github.com/apache/spark/pull/29642#discussion_r528436623
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
##########
@@ -597,12 +599,26 @@ class ParquetFilters(
createFilterHelper(pred, canPartialPushDownConjuncts = false)
.map(FilterApi.not)
- case sources.In(name, values) if canMakeFilterOn(name, values.head)
- && values.distinct.length <= pushDownInFilterThreshold =>
- values.distinct.flatMap { v =>
- makeEq.lift(nameToParquetField(name).fieldType)
- .map(_(nameToParquetField(name).fieldNames, v))
- }.reduceLeftOption(FilterApi.or)
+ case sources.In(name, values) if pushDownInFilterThreshold > 0 &&
Review comment:
It seems only Parquet is not well supported `In` predicate pushdown.
Parquet vs ORC:
https://github.com/apache/spark/blob/f5118f81e395bde0cd8253dbef6a9e6455c3958a/sql/core/benchmarks/FilterPushdownBenchmark-results.txt#L439-L482
CSV:
https://github.com/apache/spark/pull/29642#issuecomment-730869008
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
