MaxGekk commented on a change in pull request #30452:
URL: https://github.com/apache/spark/pull/30452#discussion_r528489451
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/connector/InMemoryPartitionTable.scala
##########
@@ -96,4 +97,25 @@ class InMemoryPartitionTable(
override protected def addPartitionKey(key: Seq[Any]): Unit = {
memoryTablePartitions.put(InternalRow.fromSeq(key), Map.empty[String,
String].asJava)
}
+
+ override def listPartitionByNames(
+ names: Array[String],
+ ident: InternalRow): Array[InternalRow] = {
+ assert(names.length == ident.numFields,
+ s"Number of partition names (${names.length}) must be equal to " +
+ s"the number of partition values (${ident.numFields}).")
+ val schema = partitionSchema
+ assert(names.forall(fieldName => schema.fieldNames.contains(fieldName)),
+ s"Some partition names ${names.mkString("[", ", ", "]")} don't belong to
" +
+ s"the partition schema '${schema.sql}'.")
+ val indexes = names.map(schema.fieldIndex)
+ val dataTypes = names.map(schema(_).dataType)
Review comment:
The names should be normalized after
https://github.com/apache/spark/pull/30454, so, we shouldn't care of case
sensitivity here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
