cloud-fan commented on a change in pull request #30412:
URL: https://github.com/apache/spark/pull/30412#discussion_r528875470
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
##########
@@ -94,6 +94,10 @@ trait CheckAnalysis extends PredicateHelper {
case p if p.analyzed => // Skip already analyzed sub-plans
+ case p if
p.output.map(_.dataType).exists(CharVarcharUtils.hasCharVarchar) =>
+ throw new IllegalStateException(
+ "[BUG] logical plan should not have output of char/varchar type: " +
p)
Review comment:
I choose `IllegalStateException` because this should not happen. Thanks
for catching this corner case and I've fixed it in `DataType.fromDDL`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
