Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/5513#discussion_r28392046
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Column.scala ---
@@ -515,14 +515,15 @@ class Column(protected[sql] val expr: Expression)
extends Logging {
def rlike(literal: String): Column = RLike(expr, lit(literal).expr)
/**
- * An expression that gets an item at position `ordinal` out of an array.
+ * An expression that gets an item at position `ordinal` out of an array,
+ * or gets a value by key `key` in a [[MapType]].
*
* @group expr_ops
*/
- def getItem(ordinal: Int): Column = GetItem(expr, Literal(ordinal))
+ def getItem(key: Any): Column = GetItem(expr, Literal(key))
--- End diff --
The `GetItem` operation is designed for both array and map. But to make the
name consistent with
[GetItem](https://github.com/apache/spark/blob/master/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypes.scala#L29),
I think we should keep the name but only change the type to `Any`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
